Fix example code block padding for PHP 8.3+ #1501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElfSundae
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
This was referenced Oct 19, 2025
Contributor
|
🚀 Regression report for commit 9799963 is at https://web-php-regression-report-pr-1501.preview.thephp.foundation |
Contributor
|
🚀 Preview for commit 9799963 can be found at https://web-php-pr-1501.preview.thephp.foundation |
sy-records
requested changes
Nov 12, 2025
Co-authored-by: Luffy <52o@qq52o.cn>
sy-records
approved these changes
Nov 13, 2025
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the missing padding in example code blocks introduced by changes in PHP 8.3+.
Since
highlight_string()now returns<pre><code>...</code></pre>instead of<code>...</code>, the existing CSS rule targeting only<code>no longer applied.The fix adds
<pre>to the selector so both cases are covered:+.docs .example-contents > .phpcode > pre, .docs .example-contents > .phpcode > code { padding: .75rem; }This ensures that the padding style is correctly applied to all example code blocks.